asan: leak in bfd_section_from_shdr
Alan Modra
amodra@gmail.com
Tue Nov 3 00:08:45 GMT 2020
* elf.c (bfd_section_from_shdr): Free sections_being_created.
Use bfd_zmalloc.
diff --git a/bfd/elf.c b/bfd/elf.c
index 549f661b9d..3163d34e8d 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -2061,17 +2061,19 @@ bfd_section_from_shdr (bfd *abfd, unsigned int shindex)
rather than being held in a static pointer. */
if (sections_being_created_abfd != abfd)
- sections_being_created = NULL;
+ {
+ free (sections_being_created);
+ sections_being_created = NULL;
+ }
if (sections_being_created == NULL)
{
size_t amt = elf_numsections (abfd) * sizeof (bfd_boolean);
/* PR 26005: Do not use bfd_zalloc here as the memory might
be released before the bfd has been fully scanned. */
- sections_being_created = (bfd_boolean *) bfd_malloc (amt);
+ sections_being_created = (bfd_boolean *) bfd_zmalloc (amt);
if (sections_being_created == NULL)
return FALSE;
- memset (sections_being_created, FALSE, amt);
sections_being_created_abfd = abfd;
}
if (sections_being_created [shindex])
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list