[PATCH] ld: Add --warn-textrel and obsolete --warn-shared-textrel

Alan Modra amodra@gmail.com
Wed May 27 07:32:50 GMT 2020


On Mon, May 25, 2020 at 06:51:26AM -0700, H.J. Lu via Binutils wrote:
> bfd/
> 
> 	PR ld/22909
> 	* elflink.c (bfd_elf_final_link): Use bfd_link_textrel_check.
> 	Check bfd_link_dll when issue a DT_TEXTREL warning.
> 	* elfxx-x86.c (maybe_set_textrel): Likewise.
> 	(_bfd_x86_elf_size_dynamic_sections): Likewise.
> 
> include/
> 
> 	PR ld/22909
> 	* bfdlink.h (textrel_check_method): New enum.
> 	(bfd_link_textrel_check): New.
> 	(bfd_link_info): Replace warn_shared_textrel and error_textrel
> 	with textrel_check.
> 	* elf/common.h: Update comments for ET_EXEC and ET_DYN.
> 
> ld/
> 
> 	PR ld/22909
> 	* NEWS: Mention --warn-textrel.
> 	* ld.texi: Update -z text/notext/textoff.  Add --warn-textrel.
> 	Remove --warn-shared-textrel.
> 	* ldlex.h (option_values): Rename OPTION_WARN_SHARED_TEXTREL to
> 	OPTION_WARN_TEXTREL.
> 	* lexsup.c (ld_options): Add --warn-textrel.  Obsolete
> 	--warn-shared-textrel.
> 	(parse_args): Updated.
> 	(elf_shlib_list_options): Check link_info.textrel_check.
> 	* emultempl/elf.em: Updated.
> 	* testsuite/ld-elf/pr19539.d: Replace -z notext with
> 	--warn-textrel.  Expect a warning.
> 	* testsuite/ld-i386/warn1.d: Update expected warning.

Looks good.

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list