Commit: Changing readelf's lint mode

[Nick Clifton]

Hi Guys,

  I have had a change of heart about readelf's lint mode.  I now think
  that it would be better to leave the existing warning messages alone
  and only make new warnings test for lint-mode being enabled, and then
  only if they are of file-quality type rather than a file-problem type.

  So I am checking the attached patch to revert my changes to the warn()
  function, restoring it to its old behaviour.  In the course of doing
  this I also came across a bug in line number table decoder which was
  not coping with an empty DWARF-5 format line number table.  So I have
  fixed this as well.

Cheers
  Nick

binutils/ChangeLog
2020-05-05  Nick Clifton  <nickc@redhat.com>

	* dwarf.c (do_checks): New global variable.
	(display_formatted_table): Warn about an unexpected number of
	columns in the table, if checks are enabled.  Do not complain
	about the lack of data following the number of entries in the
	table if the table is empty.
	(display_debug_lines_decoded): Only warn about an unexpected
	number of columns in a table if checks are enabled.
	* dwarf.h (do_checks): Add a prototype.
	* elfcomm.c (error): Remove weak attribute.
	(warn): Likewise.
	* readelf.c (do_checks): Delete.
	(warn): Delete.
	(process_section_headers): Only warn about empty sections if
	checks are enabled.

gas/ChangeLog
2020-05-05  Nick Clifton  <nickc@redhat.com>

	* dwarf2dbg.c (out_dir_and_file_list): Add comments describing the
	construction of a DWARF-5 directory name table.
	* testsuite/gas/elf/pr25917.d: Update expected output.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: readelf-lint.patch
Type: text/x-patch
Size: 6949 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20200505/6bd62555/attachment.bin>