[GAS] change of ELF flags initial value in rx-linux

Gunther Nikl gnikl@justmail.de
Mon May 4 18:51:52 GMT 2020


[resent with binutils@ added]

Hello!

Setting the value of elf_flags every time in md_parse_option is not necessary.
Using the same approach as done for rx_use_conventional_section_names should
have the same effect. Note, I did not move elf_flags into that block because
of the comment preceding elf_flags.

Regards,
Gunther Nikl

gas/ChangeLog
2020-05-XX  Gunther Nikl <gnikl@justmail.de>

	* config/tc-rx.c (elf_flags): Initialize for non-linux targets.
	  (md_parse_option): Remove initialization of elf_flags.
---
diff --git a/gas/config/tc-rx.c b/gas/config/tc-rx.c
index e3521d3193..3ae2635724 100644
--- a/gas/config/tc-rx.c
+++ b/gas/config/tc-rx.c
@@ -42,13 +42,16 @@ const char EXP_CHARS[]            = "eE";
 const char FLT_CHARS[]            = "dD";
 

 /* ELF flags to set in the output file header.  */
+#ifndef TE_LINUX
+static int elf_flags = E_FLAG_RX_ABI;
+#else
 static int elf_flags;
+#endif
 
 #ifndef TE_LINUX
 bfd_boolean rx_use_conventional_section_names = FALSE;
 #else
 bfd_boolean rx_use_conventional_section_names = TRUE;
-static int elf_flags;
 #endif
 static bfd_boolean rx_use_small_data_limit = FALSE;
 
@@ -130,9 +133,6 @@ struct cpu_type  cpu_type_list[] =
 int
 md_parse_option (int c ATTRIBUTE_UNUSED, const char * arg ATTRIBUTE_UNUSED)
 {
-#ifndef TE_LINUX
-  elf_flags = E_FLAG_RX_ABI;
-#endif
   switch (c)
     {
     case OPTION_BIG:
---



More information about the Binutils mailing list