[PATCH 1/6] x86: allow opcode templates to be templated

[H.J. Lu]

On Fri, Mar 6, 2020 at 6:51 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 06.03.2020 15:42, H.J. Lu wrote:
> > On Fri, Mar 6, 2020 at 12:11 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> In order to reduce redundancy as well as the chance of things going out
> >> of sync (see a later patch for an example), make the opcode table
> >> generator capable of recognizing and expanding templated templates. Use
> >> the new capability for compacting the general purpose conditional insns.
> >>
> >> opcodes/
> >> 2020-03-XX  Jan Beulich  <jbeulich@suse.com>
> >>
> >>         * i386-gen.c (struct template_arg, struct template_instance,
> >>         struct template_param, struct template, templates,
> >>         parse_template, expand_templates): New.
> >>         (process_i386_opcodes): Various local variables moved to
> >>         expand_templates. Call parse_template and expand_templates.
> >>         * i386-opc.tbl (cc): New. Use it for Jcc, SETcc, and CMOVcc.
> >>         * i386-tbl.h: Re-generate.
> >
> > OK.  Thanks.
> >
> >> ---
> >> The set* templates lack No_bSuf - is there an expectation that in AT&T
> >> mode a 'b' suffix may be used on them? Otherwise this should be added
> >
> > What does setb do?
>
> setb is just a normal mnemonic. I'm wondering about setbb or setnzb or
> alike.
>

setXX takes a byte operand.  'b' suffix is appropriate.

-- 
H.J.