PR 25562: New binutils testsuite failures
Nick Clifton
nickc@redhat.com
Mon Mar 30 15:29:35 GMT 2020
Hi Guys,
Right, I am checking in the attached patch which makes objcopy's -p
work with PE format files. I had to change the insert_timestamp field
in the pe_data structure to an integer containing the time to put in
the header. The value can be 0 for a deterministic output, and it can
also be -1, which is interpreted as 'insert the current time'.
I have rerun the pr25662 tests with this change and all of the PE
format targets now pass.
Cheers
Nick
bfd/ChangeLog
2020-03-30 Nick Clifton <nickc@redhat.com>
PR binutils/pr25662
* libcoff-in.h (struct pe_tdata): Rename the insert_timestamp
field to timestamp and make it an integer.
* libcoff.h: Regenerate.
* peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Test the timestamp
field in the pe_data structure rather than the insert_timestamp
field.
binutils/ChangeLog
2020-03-30 Nick Clifton <nickc@redhat.com>
PR binutils/25662
* objcopy.c (copy_object): When copying PE format files set the
timestamp field in the pe_data structure if the preserve_dates
flag is set.
* testsuite/binutils-all/objcopy.exp (objcopy_test) Use
--preserve-dates in place of the -p option, in order to make its
effect more obvious.
ld/ChangeLog
2020-03-30 Nick Clifton <nickc@redhat.com>
PR binutils/25662
* emultempl/pe.em (after_open): Replace initialisation of the
insert_timestamp field in the pe_data structure with an
initialisation of the timestamp field.
* emultemp/pep.em: Likewise.
* pe-dll.c (fill_edata): Use the timestamp field in the pe_data
structure instead of the insert_timestamp field.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr25662.patch
Type: text/x-patch
Size: 4590 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20200330/6b728e31/attachment.bin>
More information about the Binutils
mailing list