[PATCH] Add testcase for PR 25662 invalid sh_offset for section

Hans-Peter Nilsson hp@bitrange.com
Fri Mar 27 21:03:07 GMT 2020


On Fri, 27 Mar 2020, Jozef Lawrynowicz wrote:
> On Fri, 27 Mar 2020 07:55:12 +1030
> Alan Modra <amodra@gmail.com> wrote:
> > OK, thanks.  Yes, we are going to have some fails with this new test.
> > Hmm, objcopy -p doesn't help with the PE date stamp and it seems like
> > it should.
> >
> > You might like to simplify the LD test.
> >
> > > +	set status [remote_exec host $LD -v]
> > > +	if { [lindex $status 0] != 0 } {
> >
> >       if {[which $LD] == 0} then {
> >
> > > +	    untested "objcopy $type ($testname)"
> > > +	    return
> > > +	}
> >
>
> Thanks for the tip. Fixed that and pushed to master.

Your 1fafefd59438 seems to have caused a new failure for my
binutils autotester.  With --target mmix-knuth-mmixware:

(edited copypaste, line breaks may be wrong)

...
Running x/src/binutils/testsuite/binutils-all/objcopy.exp ...
Version x/binutils/objcopy 2.34.50.20200327
FAIL: objcopy executable (pr25662)
...

In binutils.log:
...
Executing on host: x/binutils/objcopy  tmpdir/bintest tmpdir/copy   (timeout = 300)
spawn -ignore SIGHUP x/binutils/objcopy tmpdir/bintest tmpdir/copy
cmp tmpdir/bintest tmpdir/copy
Executing on build: cmp tmpdir/bintest tmpdir/copy   (timeout = 300)
spawn -ignore SIGHUP cmp tmpdir/bintest tmpdir/copy
tmpdir/bintest tmpdir/copy differ: char 18, line 1
tmpdir/bintest tmpdir/copy differ: char 18, line 1

FAIL: objcopy executable (pr25662)
...

Could you please look into this?
Thanks.

brgds, H-P



More information about the Binutils mailing list