[PATCH][MIPS][Committed] Fix PR/gas 25539 fix_loongson3_llsc: fix when target has multi labels
Maciej W. Rozycki
macro@linux-mips.org
Tue Mar 17 01:42:35 GMT 2020
On Fri, 28 Feb 2020, Paul Hua wrote:
> When there is multi-labels on the same insn, the current code
> will take care about the last one. it may cause that no sync
> is added at the target.
Why do you need to set an arbitrary limit as to the number of labels
handled (MAX_LABELS_SAME)? This handles user-supplied input, so we can't
predict how many there will be at most. What happens if the limit has
been exceeded?
We should avoid setting unnecessary limits, as per our coding standards:
<https://www.gnu.org/prep/standards/standards.html#Semantics>.
Maciej
More information about the Binutils
mailing list