non-contiguous elf test

Christophe Lyon christophe.lyon@linaro.org
Mon Mar 16 10:21:01 GMT 2020


On Sat, 14 Mar 2020 at 07:52, Alan Modra <amodra@gmail.com> wrote:
>
> This test XPASSes on the generic ELF targets, so adjusting.  I also
> made xtensa an xfail instead of a skip, since skip is hiding some
> nastiness.
>
> Christophe please do fix that abort.  An abort is appropriate on a
> condition that is not supposed to happen, giving "please report this
> bug".  It shouldn't be used just for unsupported options.

OK, sure, but what's the recommended way of issuing a fatal error message?
I'd like to stop processing at that point (and similarly in the other
parts of my patch where I use abort)

Thanks

>
>         * testsuite/ld-elf/non-contiguous.d: Don't xfail generic ELF
>         targets.  Don't skip xtensa, xfail instead.
>
> diff --git a/ld/testsuite/ld-elf/non-contiguous.d b/ld/testsuite/ld-elf/non-contiguous.d
> index 9694bcf933..0c76fcbab6 100644
> --- a/ld/testsuite/ld-elf/non-contiguous.d
> +++ b/ld/testsuite/ld-elf/non-contiguous.d
> @@ -2,8 +2,7 @@
>  #source: non-contiguous.s
>  #ld: --enable-non-contiguous-regions -T non-contiguous.ld
>  #objdump: -rdsh
> -#xfail: [is_generic]
> -#skip: xtensa*
> +#xfail: xtensa*
>
>  .*:     file format .*
>
>
> --
> Alan Modra
> Australia Development Lab, IBM



More information about the Binutils mailing list