[PATCH 29/59] libctf: pass the thunk down properly when wrapping qsort_r
Nick Alcock
nick.alcock@oracle.com
Tue Jun 30 23:31:16 GMT 2020
When wrapping qsort_r on a system like FreeBSD on which the compar
argument comes first, we wrap the passed arg in a thunk so we can pass
down both the caller-supplied comparator function and its argument. We
should pass the *argument* down to the comparator, not the thunk, which
is basically random nonsense on the stack from the point of view of the
caller of qsort_r.
libctf/
ctf-decls.h (ctf_qsort_compar_thunk): Fix arg passing.
---
libctf/ctf-decls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libctf/ctf-decls.h b/libctf/ctf-decls.h
index 51041c592f4..c47a72e722f 100644
--- a/libctf/ctf-decls.h
+++ b/libctf/ctf-decls.h
@@ -46,7 +46,7 @@ ctf_qsort_compar_thunk (void *arg, const void *a, const void *b)
{
struct ctf_qsort_arg *qsort_arg = (struct ctf_qsort_arg *) arg;
- return qsort_arg->compar (a, b, arg);
+ return qsort_arg->compar (a, b, qsort_arg->arg);
}
static inline void
--
2.27.0.247.g3dff7de930
More information about the Binutils
mailing list