[PATCH users/roland/ld-start-stop-visibility] gold, ld: Implement -z start-stop-visibility=... option.

Fangrui Song i@maskray.me
Tue Jun 16 15:48:24 GMT 2020


On 2020-06-15, Roland McGrath via Binutils wrote:
>On Sat, Jun 13, 2020 at 4:43 PM Cary Coutant <ccoutant@gmail.com> wrote:
>> Please use DEFINE_enum instead, and then convert to an STV value in
>> General_options::finalize(). See the code for the --icf or
>> --orphan-handling options for an example.
>
>Done and committed.
>
>Thanks,
>Roland

I see that your original message included quite a bit of description
while commit cae64165f47b64898c4f1982d294862cfae89a47 dropped most of
them.

To understand this practice, I have found the justification in 
https://www.gnu.org/prep/standards/html_node/Change-Log-Concepts.html#Change-Log-Concepts

"The best place to explain how parts of the new code work with other code
is in comments in the code, not in the change log."

However, many modern binutils-gdb commits add rationale to the git descriptions.
The practice is adopted by most influential projects:)
Is there a need to amend
https://www.gnu.org/prep/standards/html_node/Change-Log-Concepts.html#Change-Log-Concepts
?


More information about the Binutils mailing list