[PATCH] aarch64: set sh_entsize of .plt to 0

[Szabolcs Nagy]

The 07/30/2020 16:35, Nick Clifton wrote:
> Hi Szabolcs,
> 
> > This patch sets sh_entsize of .plt to 0: the section does not
> > hold a table of fixed-size entries so other values are not
> > conforming in principle to the ELF spec.
> 
> Given this statement, wouldn't it make more sense for the patch
> to change this:
> 
> > -  elf_section_data (htab->root.splt->output_section)->this_hdr.sh_entsize =
> > -    htab->plt_header_size;
> 
> Into this:
> 
>   /* PR 26312: Explicitly set the sh_entsize to 0 so that
>      consumers do not think that the section contains fixed
>      sized objects.  */
>   elf_section_data (htab->root.splt->output_section)->this_hdr.sh_entsize = 0;

thanks, committed with that change.

> 
> 
> And similarly later on ?

the second case was just overriding the first setting
so it did not seem necessary to explicitly set 0
again.

> 
> I know that the field is probably already 0, but it is best to make
> sure, and a comment always helps.
> 
> Approved with this change, should you agree to it.
> 
> Cheers
>   Nick
> 

--