Allow new just-symbols test to run on XCOFF and PE

Maciej W. Rozycki macro@wdc.com
Mon Jul 27 14:15:05 GMT 2020


On Mon, 27 Jul 2020, Alan Modra via Binutils wrote:

> 	* testsuite/ld-misc/just-symbols.exp: Run for x86_64 PE too.
> 	Set LDFLAGS for PE and XCOFF.
> 	* testsuite/ld-misc/just-symbols.ld: Accept XCOFF mapped .data.
> 
> diff --git a/ld/testsuite/ld-misc/just-symbols-1.dd b/ld/testsuite/ld-misc/just-symbols-1.dd
> index 8908a235ae..9502566ac9 100644
> --- a/ld/testsuite/ld-misc/just-symbols-1.dd
> +++ b/ld/testsuite/ld-misc/just-symbols-1.dd
> @@ -1,5 +1,3 @@
> -.*: +file format .*
> -
> -Contents of section \.data:
> +#...
>   [0-9a-f]+ (?:(:?12000000|00120000|00000012) 0{8}|0{8} 00000012) 0{8} 0{8} .*
>  #pass

 This breaks one purpose of the test case, that is ensuring that data from 
the input `.data' section coming from just-symbols-1.o is first in the 
output `.data' section; that is that `--just-symbols' actually works as 
intended and does not pull contents from just-symbols-0.o/just-symbols-0. 

 Sorry not to have been clear about it in the change description of commit 
97c79e2174fb ("PR ld/26288: Allow the use of `--just-symbols' with ET_EXEC 
input").

 Would you be able to update your change to keep that purpose?  What's 
there with the affected targets that causes extra data to be present 
ahead?

  Maciej


More information about the Binutils mailing list