[PATCH 4/5] Refine size constraints applied to win32pstatus ELF notes

Nick Clifton nickc@redhat.com
Mon Jul 13 15:04:00 GMT 2020


Hi Jon,

>      case NOTE_INFO_PROCESS:
> +      if (note->descsz < 12)
> +        return TRUE;
> +

Shouldn't this return, and the later ones, be "return FALSE" ?
After all you have a note type but insufficient space for valid note data.

Actually it looks to me like almost all of the returns in this function
should be "return FALSE" as there is something wrong with the note...

Cheers
  Nick
 



More information about the Binutils mailing list