[PATCH 0/4] bfd: Add support for Cygwin x86_64 core dumps

Nick Clifton nickc@redhat.com
Thu Jul 9 13:38:35 GMT 2020


Hi Jon,

> Fixes and additions support x86_64 in reading the NT_WIN32PSTATUS ELF notes
> in a Cygwin "core dump".

The patch series looks fine to me apart from one thing:

>From patch 2/4:

  -  if (note->descsz < 728)
  -    return TRUE;

Without this check it will be possible for a corrupt core file
to trigger invalid reads beyond the end of the note section.
(Binary fuzzers love triggering this kind of bug).  So I think
that everywhere you read data from a note you should make sure
that there actually is data present first.

Cheers
  Nick



More information about the Binutils mailing list