Commit: Fix GOLD testsuite failures for 2.35 branch

Cary Coutant ccoutant@gmail.com
Mon Jul 6 17:00:43 GMT 2020


> >      if (strcmp(name, ".eh_frame") == 0
> > -     || strncmp(name, ".gnu.build.attributes", 21) == 0
> > +#define ATTR_SECTION_PREFIX ".gnu.build.attributes"
> > +     || strncmp(name, ATTR_SECTION_PREFIX, sizeof ATTR_SECTION_PREFIX) == 0
>
> You want strlen or sizeof - 1.  CONST_STRNEQ would be even better, if
> gold wasn't such an alien part of binutils.

Actually, you want is_prefix_of, defined in gold.h.

With that, it's OK for trunk.

-cary


More information about the Binutils mailing list