Recent change causing s390x binutils builds to fail

Nick Clifton nickc@redhat.com
Fri Jan 31 16:43:00 GMT 2020


Hi Jeff,

> Somewehre between a2236a08440996fe2adb5f9b61926db9a9e8c8c3
> and 0c115f8483ac32dc95fde902cac8c8bb99f9c3be  s390x native builds have
> started failing.
> 
>> ../../../binutils/gas/config/tc-s390.c:899:10: error: implicit conversion from ‘enum bfd_reloc_code_real’ to ‘elf_suffix_type’ [-Werror=enum-conversion]
>>   899 |   return BFD_RELOC_UNUSED;

I think that was due to a simple thinko on the contributor's
part.  I have checked in what I hope is the obvious patch to
fix the problem.

Cheers
  Nick

gas/ChangeLog
2020-01-31  Nick Clifton  <nickc@redhat.com>

	* config/tc-s390.c (s390_elf_suffix): Return ELF_SUFFIX_NONE
	rather than BFD_RELOC_NONE.

diff --git a/gas/config/tc-s390.c b/gas/config/tc-s390.c
index ebd3e17d2e..7f004d8f29 100644
--- a/gas/config/tc-s390.c
+++ b/gas/config/tc-s390.c
@@ -896,7 +896,7 @@ s390_elf_suffix (char **str_p, expressionS *exp_p)
        return ptr->suffix;
       }
 
-  return BFD_RELOC_UNUSED;
+  return ELF_SUFFIX_NONE;
 }
 
 /* Structure used to hold a literal pool entry.  */



More information about the Binutils mailing list