[PATCH 3/3] Identify reproducible builds in 'objdump -p' output for PE files

Jon Turney jon.turney@dronecode.org.uk
Thu Jan 30 13:08:00 GMT 2020


On 28/01/2020 22:18, Alan Modra wrote:
> On Tue, Jan 21, 2020 at 03:52:12PM +0000, Jon Turney wrote:
>> 	* peXXigen.c (pe_is_repro): New function.
>> 	(_bfd_XX_print_private_bfd_data_common): Note timestamp is
>> 	actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
> 
> OK, except
> 
>> +  if ((section == NULL) ||
>> +      (!(section->flags & SEC_HAS_CONTENTS)) ||
>> +      (section->size < size))
> 
> Please fix the trailing operators.
> 
>    if (section == NULL
>        || !(section->flags & SEC_HAS_CONTENTS)
>        || section->size < size)
> 

Thanks.

Pushed with that correction.



More information about the Binutils mailing list