[PATCH 2/2] z/OS support: Introducing z/OS support

[Alan Modra]

On Sun, Jan 26, 2020 at 07:37:56PM +0800, David Lanzenörfer wrote:
>  create mode 100644 bfd/po-bfd.h
>  create mode 100644 bfd/po64-s390.c
>  create mode 100644 include/po/common.h
>  create mode 100644 include/po/external.h
>  create mode 100644 include/po/internal.h
>  create mode 100644 ld/emulparams/po64_s390.sh
>  create mode 100644 ld/scripttempl/po64_s390.sc

These are really jarring names to anyone who is accustomed to po files
as Gettext Portable Object files.  Please change them.  zpo maybe.
You also have a lot of identifiers starting with po, those also would
be better as zpo or something else.

> +    _bfd_dummy_target,
> +    _bfd_dummy_target, /* TODO: bfd_po_object_p */
> +    _bfd_dummy_target,
> +    _bfd_dummy_target

Without an object_p function BFD can't read your object files!  So
this is a write-only format.  You can't inspect symbols, you can't
objcopy or objdump the files.  How do you test anything?

-- 
Alan Modra
Australia Development Lab, IBM