[PATCH] RISC-V: Fix gdbserver problem with handling arch strings.

[Jim Wilson]

On Fri, Jan 24, 2020 at 5:32 AM Maciej W. Rozycki <macro@wdc.com> wrote:
>  I think it's an acceptable solution short-term; after all it's not going
> to regress functionality.  However ultimately I think we ought to actually
> interpret these suffix letters and arm the disassembler accordingly.

The strings are checked when used as options, and when used in elf
attributes.  I'm not sure if they need to be checked here, but it is
probably a good idea to do that eventually.  Checking the strings for
correctness is complicated, as there are many different possible
correct answers, which is why I didn't try to do it in the first
version of the patch.  it would be nice to reuse some of the other
support, maybe the attribute merging support, but it would have to be
rewritten a bit to make this work.  I'd rather worry about that later,
or ask someone else to do it.

>  I'd suggest naming the new function `riscv_scan' or suchlike, even though
> it's static, so as not to pollute the generic namespace.  We even have a
> precedent already with `riscv_compatible' nearby.

arm and aarch64 are the only ports that define such a function, and
they both call it scan.  But I agree that riscv_scan is better.  I
changed it.

Jim