[PATCH v3 03/10] x86: move certain MOVSX/MOVZX tests

H.J. Lu hjl.tools@gmail.com
Thu Jan 23 13:43:00 GMT 2020


On Thu, Jan 23, 2020 at 5:13 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 23.01.2020 13:52, H.J. Lu wrote:
> > On Thu, Jan 23, 2020 at 2:38 AM Jan Beulich <jbeulich@suse.com> wrote:
> >>
> >> On 22.01.2020 18:31, H.J. Lu wrote:
> >>> I am checking in this patch.
> >>
> >> Hard to believe that you don't even give people any chance to comment.
> >>
> >>> --- a/gas/ChangeLog
> >>> +++ b/gas/ChangeLog
> >>> @@ -1,3 +1,15 @@
> >>> +2020-01-22  H.J. Lu  <hongjiu.lu@intel.com>
> >>> +
> >>> +     PR gas/25438
> >>> +     * config/tc-i386.c (check_long_reg): Always disallow double word
> >>> +     suffix in mnemonic with word general register.
> >>
> >> What about check_byte_reg() and check_word_reg()? I can only repeat
> >> again - the assembler should behave consistently in regards like
> >> this one.
> >
> > Please add more examples to PR gas/25438.
>
> What? I'm sorry, but I'm starting to get upset, also seeing your

Please give examples for issues with check_byte_reg() and check_word_reg()
in  PR gas/25438.

> completely ignorant "Please submit a single patch to fix this bug"
> you've just added to that bug (but I'll reply there).
>

I looked at your changes.   Your patches move codes around more
than once, which can be done in a patch.

-- 
H.J.



More information about the Binutils mailing list