[PATCH v2] RISC-V: Change -march parsing.

[Jim Wilson]

On Thu, Jan 9, 2020 at 11:40 AM Jim Wilson <jimw@sifive.com> wrote:
> On Wed, Jan 8, 2020 at 10:20 PM Kito Cheng <kito.cheng@gmail.com> wrote:
> > Ping, do you mind accept this patch and then we'll send follow up
> > patch for Zifence and Zicsr?

I finally got back to this for real.

I see a curious comment
+        For 's', it must be known from a list and also *can* simply be 's'.  *\
except the code does not allow s by itself, and I don't see anything
in the ISA spec that allows s by itself.  It isn't obvious what the
intent here was, so I left this alone for now, but I consider this a
bug that needs to be fixed, either by fixing the code to match the
comment, or the comment to match the code.  I suspect the latter is
the correct fix.  Maybe this is left over from when we still supported
sx?

I also noticed that there are now H* extensions documented in the ISA
manual, but I think these were added after this discussion started, so
this can be fixed later.  It should be easy to add H support same as
s/x/z support.

Otherwise this looks OK to me.

I noticed 3 functions were missing comments; I added them.  I fixed a
couple of lines that were too long.  There was a comment
+/* Parsing order that is needed for bitmanip.  */
I changed it to
/* Parsing order that is specified by the ISA manual.  */
I rewrote the ChangeLog entries.  The gas entries were written for the
wrong directory, as gas testsuite ChangeLog entries go in the toplevel
gas dir.  The bfd entries were missing some of the function changes,
had unnecessary quotes around function names, and had a few typos.
None of these changes affect how the patch works.

I'm approving the patch, and committed my slightly modified version of it.

Jim