V3 [PATCH 4/4] i386: Add tests for -malign-branch-boundary and -malign-branch

[H.J. Lu]

On Tue, Dec 24, 2019 at 11:08 PM Hongtao Liu <crazylht@gmail.com> wrote:
>
> On Fri, Dec 20, 2019 at 10:56 AM Hongtao Liu <crazylht@gmail.com> wrote:
> >
> > On Mon, Dec 16, 2019 at 10:34 AM Alan Modra <amodra@gmail.com> wrote:
> > >
> > > i686-pc-elf  +FAIL: ld-i386/align-branch-1
> > >
>
> This is because
> ---cut from gas.log-------
> regexp_diff match failure
> regexp "^ +[a-f0-9]+:   74 20                   je     8049024 <_start\+0x24>$"
> line   " 80480a2:       74 20                   je     80480c4 <_start+0x24>"
> ----end of cut--------------
>
> > > i386-darwin  +FAIL: gas/i386/align-branch-1a
> > > i386-darwin  +FAIL: gas/i386/align-branch-1b
> > > i386-darwin  +FAIL: gas/i386/align-branch-1c
> > > i386-darwin  +FAIL: gas/i386/align-branch-1d
> > > i386-darwin  +FAIL: gas/i386/align-branch-1e
> > > i386-darwin  +FAIL: gas/i386/align-branch-1f
> > > i386-darwin  +FAIL: gas/i386/align-branch-1g
> > > i386-darwin  +FAIL: gas/i386/align-branch-1h
> > > i386-darwin  +FAIL: gas/i386/align-branch-1i
> > > i386-darwin  +FAIL: gas/i386/align-branch-5
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1a
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1b
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1c
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1d
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1e
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1f
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1g
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1h
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-1i
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-2a
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-2b
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-2c
> > > i386-darwin  +FAIL: gas/i386/x86-64-align-branch-5
> > >
> These are because
> 1.darwin use label to jump, format is not same with orginal *.d file
> ------cut from gas.log-----------
> regexp_diff match failure
> regexp "^  22:  74 5e                   je     82 <foo\+0x82>$"
> line   "  22:   74 5e                   je     82 <.L_2>"
> ------end of cut------------------
>
> 2.darwin cannot recognize call *foo under 64bit mode
> ------cut from gas.log-----------
> /export/users2/liuhongt/binutils/gas/testsuite/gas/i386/x86-64-align-branch-2.s:
> Assembler messages:
> /export/users2/liuhongt/binutils/gas/testsuite/gas/i386/x86-64-align-branch-2.s:43:
> Error: cannot represent relocation type BFD_RELOC_X86_64_32S
> ------end of cut-------------------
>
> > > --
> > > Alan Modra
> > > Australia Development Lab, IBM
> >
> > I'll take a look.
> >
> > --
> > BR,
> > Hongtao
>
> So, update testcase.
>

This is the patch I am checking in.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-Updated-align-branch-tests-for-Darwin-and-i686-p.patch
Type: text/x-patch
Size: 65173 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20200114/1175d14c/attachment.bin>