[PATCH v3 10/10] x86-64: Intel64 adjustments for insns dealing with far pointers

Jan Beulich jbeulich@suse.com
Tue Jan 14 15:01:00 GMT 2020


On 13.01.2020 18:42, H.J. Lu wrote:
> On Fri, Dec 27, 2019 at 1:27 AM Jan Beulich <JBeulich@suse.com> wrote:
>>
>> AMD and Intel differ in their handling of far indirect branches as well
>> as LFS/LGS/LSS: AMD CPUs ignore REX.W while Intel ones honors it. (Note
>> how the latter three were hybrids so far, while far branches were fully
>> AMD-like.)
>>
>> gas/
>> 2020-01-XX  Jan Beulich  <jbeulich@suse.com>
>>
>>         PR gas/24546
>>         * config/tc-i386.c (match_template): Apply AMD64/Intel64 check
>>         to 64-bit code only.
>>         * config/tc-i386.c (i386_intel_operand): Also handle CALL/JMP in
>>         O_tbyte_ptr case.
>>         * testsuite/gas/i386/x86-64-branch-3.s,
>>         testsuite/gas/i386/x86-64-intel64.s: Add 64-bit far call cases.
>>         * testsuite/gas/i386/x86-64-branch-3.d,
>>         testsuite/gas/i386/x86-64-intel64.d: Adjust expectations.
>>         * testsuite/gas/i386/x86-64-branch-5.l,
>>         testsuite/gas/i386/x86-64-branch-5.s: New.
>>         * testsuite/gas/i386/i386.exp: Run new test.
>>
>> opcodes/
>> 2020-01-XX  Jan Beulich  <jbeulich@suse.com>
>>
>>         PR gas/24546
>>         * i386-dis.c (putop): Handle REX.W in '^' case for Intel64 mode.
>>         * i386-opc.tbl (lfs, lgs, lss, lcall, ljmp): Split into
>>         AMD64 and Intel64 templates.
>>         (call, jmp): Likewise for far indirect variants. Dro
>>         Unspecified.
>>         * i386-tbl.h: Re-generate.
> 
> Please add some documentations to describe how they are used in
>  AMD64 and Intel64 in AT&T/Intel syntax.

There's nothing unusual or unexpected here. I wouldn't even know
where this would belong - are there descriptions like what you
ask for somewhere already for a fair set of other insns? I don't
recall any similar additions for any half way recent ISA
extensions, and there it might be better justified to supply
such than it is here. I guess I'm confused by the request ...

Jan



More information about the Binutils mailing list