[PATCH v3 08/10] x86-64: also diagnose far returns / IRET with ambiguous operand size

H.J. Lu hjl.tools@gmail.com
Mon Jan 13 17:38:00 GMT 2020


On Fri, Dec 27, 2019 at 1:20 AM Jan Beulich <JBeulich@suse.com> wrote:
>
> Other than near returns these default to 32-bit operand size, and hence
> it isn't really unlikely that 64-bit forms are meant. Hence these should
> have disambiguating suffixes. In Intel mode, however, don't error in
> these cases unconditionally - MASM accepts these without suffix _and_
> without warning.
>
> gas/
> 2020-01-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (process_suffix): .
>         testsuite/gas/i386/noreg64.s: Add IRET and LRET cases.
>         testsuite/gas/i386/x86-64-opcode.s: Add suffix to IRET and LRET.
>         Add LRETQ case.
>         testsuite/gas/i386/x86-64-suffix.s: Drop IRET case without
>         suffix.
>         testsuite/gas/i386/x86_64.s: Add RETF cases.
>         * testsuite/gas/i386/k1om.d, testsuite/gas/i386/l1om.d,
>         testsuite/gas/i386/noreg64.d, testsuite/gas/i386/noreg64.l,
>         testsuite/gas/i386/x86-64-opcode.d,
>         testsuite/gas/i386/x86-64-suffix-intel.d,
>         testsuite/gas/i386/x86-64-suffix.d,
>         testsuite/gas/i386/x86_64-intel.d
>         testsuite/gas/i386/x86_64.d: Adjust expectations.
>         * testsuite/gas/i386/x86-64-suffix.e,
>         testsuite/gas/i386/x86_64.e: New.

OK.

Thanks.


-- 
H.J.



More information about the Binutils mailing list