[PATCH v3 02/10] x86: replace adhoc ambiguous operand checking for CRC32

H.J. Lu hjl.tools@gmail.com
Mon Jan 13 17:27:00 GMT 2020


On Fri, Dec 27, 2019 at 1:19 AM Jan Beulich <JBeulich@suse.com> wrote:
>
> There's no need (anymore?) to heavily special case this - just make
> generic logic consider only its first operand, and deal with the case
> of an 'l' suffix not being allowed in a pattern.
>
> gas/
> 2020-01-XX  Jan Beulich  <jbeulich@suse.com>
>
>         * config/tc-i386.c (process_suffix): Merge CRC32 handling into
>         generic code path. Deal with No_lSuf being set in a template.
>         * testsuite/gas/i386/inval-crc32.l,
>         testsuite/gas/i386/x86-64-inval-crc32.l: Expect warning(s)
>         instead of error(s) when operand size is ambiguous.
>         * testsuite/gas/i386/noreg16.s, testsuite/gas/i386/noreg32.s,
>         testsuite/gas/i386/noreg64.s: Add CRC32 tests.
>         * testsuite/gas/i386/noreg16.d, testsuite/gas/i386/noreg16.l,
>         testsuite/gas/i386/noreg32.d, testsuite/gas/i386/noreg32.l,
>         testsuite/gas/i386/noreg64.d, testsuite/gas/i386/noreg64.l:
>         Adjust expectations.
>

OK.

Thanks.

-- 
H.J.



More information about the Binutils mailing list