On Wed, 8 Jan 2020 at 14:14, Nick Clifton <nickc@redhat.com> wrote:
>
> Hi Christophe,
>
> > There are now 4 patches, to hopefully make review/comments easier:
> > * patch1: is the main (code) patch
> > * patch2: generic test
> > * patch3: arm tests
> > * patch4: powerpc test
>
> I think that you need to test some non-ELF based targets. Or maybe a
> --enable-targets=all configuration. I am seeing this error when building:
>
> bfd/ecoff.c:81:1: error: missing initializer for field 'already_assigned' of 'asection' {aka 'struct bfd_section'} [-Werror=missing-field-initializers]
Right, I didn't try non-elf targets.
If it helps your testing, I was just missing:
diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index be3d42e..2ce2c8f 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -77,7 +77,9 @@ static asection bfd_debug_section =
/* symbol_ptr_ptr, */
NULL,
/* map_head, map_tail */
- { NULL }, { NULL }
+ { NULL }, { NULL },
+ /* already_assigned */
+ NULL,
};
/* Create an ECOFF object. */
>
> Also when adding a new feature like this, it would be nice if you could
> include a line or two in ld/NEWS describing what it does. This makes it
> easier for me to advertise the feature when announcing a new release...
>
> Also you should add a description of the option to ld/ld.texi.
Sure, I am aware of that. At this stage, I'm still looking for comments
on the design. I fear I'm doing changes in a very wrong way.
OTOH, if this approach looks fine to you, I'll make sure to submit a patch
including some docs before the 2.34 deadline :-)
Thanks,
Christophe
>
> Cheers
> Nick
>
>