[PATCH v3 4/4] RISC-V: Disable the CSR checking by default.

[Nelson Chu]

Hi Jim,

On Sat, Feb 1, 2020 at 11:08 AM Jim Wilson <jimw@sifive.com> wrote:
>
> Though now I'm wondering if maybe csrcheck
> can choose between an error and a warning.  So we have a choice here
> between error/no error or error/warning.  There is a gas option
> --fatal-warnings that will turn warnings into errors for people that
> want that.  And a --no-warn/-W option that turns warnings off, if
> people don't want the warning.

If the csr check is a warning, then do we still need to support the
-mcsr-check options?
We also generate the warning for the csr check, and user can use
--fatal-warnings and --no-warn/-W options to decide whether the
warning is needed.  It seems like we no longer need the csr check
options, is it right?

> I think -mcsrcheck is a little hard to parse, maybe -mcsr-check
> instead?  And similarly for the .option if we do that.

OK, this naming is better to parse.

> Also, not directly related to this patch, but I noticed that we are
> missing doc entries for the -march-attr/-mno-arch-attr command line
> options added a year ago.  That would be at least partly my fault for
> not asking for that during the review.  Maybe something you can add to
> your to do list.

OK, noted :)

> This fixes the csr-dw-regnums rv64 testsuite failure from the second
> patch by accident, because you didn't turn on csrchecking for that
> test.  But it should still be fixed anyways, in case someone turns
> this on by default in their copy of binutils.

Maybe we can add the -W option to the csr-dw-regnums rv64 testsuite?
or we can add the -march=rv32if option which is mentioned in the
previous mail.  I think both are workable.

Thanks
Nelson