V3 [PATCH] gas: Generate a new section for SHF_GNU_RETAIN

[H.J. Lu]

On Tue, Dec 8, 2020 at 9:08 AM Nick Clifton <nickc@redhat.com> wrote:
>
>   Hi H.J.
>
> > Can you take a look at this
> >
> > https://sourceware.org/pipermail/binutils/2020-December/114407.html
>
> I am tending towards approving this patch, although I would like to
> see if Alan has any comments.
>
> I did notice however that the patch does introduce some new failures:
>
>    GAS REGRESSION: SHF_GNU_RETAIN sections 27
>
> This was for:
>   m32r-elf
>   mipsisa32el-linux
>   tx39-elf
>   mips64el-openbsd
>   mipsel-linux-gnu
>   mips-sgi-irix6
>   mips64-linux
>   rx-elf .
>   s390-linux
>   score-elf
>   mips-elf
>   mips64-openbsd
>   nds32le-elf

BTW,  there are many extra failures for some targets.  Should we
xfail them if no one will fix them?

> The mips failures appear to be because of MIPS special sections,  eg:
>
>    regexp_diff match failure
>    regexp "^  \[..\] .bss[      ]+NOBITS[       ]+[0-9a-f]+ [0-9a-f]+ [0-9a-f]+ 00 WAR.*$"
> line   "  [ 4] .reginfo          MIPS_REGINFO    00000000 00003c 000018 01      0   0  4"
>    regexp_diff match failure
>
> I have not checked the others, but I suspect that they will be similar.
>

You are right.  Just some extra sections.  Here is the updated patch
with the adjusted testcase.

Alan, does this patch look OK to you?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gas-Generate-a-new-section-for-SHF_GNU_RETAIN.patch
Type: text/x-patch
Size: 7961 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20201208/78233428/attachment.bin>