[GOLD] gcc-11 stringop-overflow warning
Alan Modra
amodra@gmail.com
Mon Dec 7 12:05:13 GMT 2020
I'm unsure why this is deserving of a warning. Not writing the most
efficient code surely can't be a real problem, but that is what
https://gcc.gnu.org/bugzilla//show_bug.cgi?id=88059#c1 seems to say.
plugin.cc:528:10: error: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
528 | strncpy(tempdir, dir_template, len);
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
plugin.cc:526:22: note: length computed here
526 | size_t len = strlen(dir_template) + 1;
| ~~~~~~^~~~~~~~~~~~~~
Applied as obvious, or at least, not wrong.
* plugin.cc (Plugin_recorder::init): Replace strncpy with memcpy.
diff --git a/gold/plugin.cc b/gold/plugin.cc
index 729ddca9f3..fd37957e73 100644
--- a/gold/plugin.cc
+++ b/gold/plugin.cc
@@ -525,7 +525,7 @@ Plugin_recorder::init()
size_t len = strlen(dir_template) + 1;
char* tempdir = new char[len];
- strncpy(tempdir, dir_template, len);
+ memcpy(tempdir, dir_template, len);
// Create the log file.
std::string logname(tempdir);
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list