[PATCH] VAX/BFD: Do not warn about GOT addend mismatches if no GOT entry is made
Maciej W. Rozycki
macro@linux-mips.org
Fri Dec 4 20:40:49 GMT 2020
On Fri, 4 Dec 2020, Jan-Benedict Glaw wrote:
> > bfd/
> > * elf32-vax.c (elf_vax_check_relocs) <R_VAX_GOT32>: Use
> > SYMBOL_REFERENCES_LOCAL rather than `h->forced_local' to check
> > whether the symbol referred is local or not.
> >
> > ld/
> > * testsuite/ld-vax-elf/got-local-exe-off-hidden.dd: New test
> > dump.
> > * testsuite/ld-vax-elf/got-local-exe-off-visible.dd: New test
> > dump.
> > * testsuite/ld-vax-elf/got-local-lib-off-hidden.dd: New test
> > dump.
> > * testsuite/ld-vax-elf/got-local-lib-off-visible.ed: New test
> > dump.
> > * testsuite/ld-vax-elf/got-local-off-external.ed: New test dump.
> > * testsuite/ld-vax-elf/got-local-exe-off.xd: New test dump.
> > * testsuite/ld-vax-elf/got-local-lib-off.xd: New test dump.
> > * testsuite/ld-vax-elf/got-local.ld: New test linker script.
> > * testsuite/ld-vax-elf/got-local-aux-off.s: New test source.
> > * testsuite/ld-vax-elf/got-local-def-off.s: New test source.
> > * testsuite/ld-vax-elf/got-local-ref-off-external.s: New test
> > source.
> > * testsuite/ld-vax-elf/got-local-ref-off-hidden.s: New test
> > source.
> > * testsuite/ld-vax-elf/got-local-ref-off-visible.s: New test
> > source.
> > * testsuite/ld-vax-elf/vax-elf.exp: Run the new tests.
>
> Good to go!
Committed now, with a minor tweak to the description to match the current
version of the relevant test case.
> Reminds me that I'd like a pure all-opcode test case as well as one
> for all addressing modes.
Exactly my point:
On Mon, 30 Nov 2020, Maciej W. Rozycki wrote:
> NB I wish we had better target-specific coverage across the testsuites,
> like e.g. the MIPS port does. We don't even have GAS coverage for basic
> machine code generation, i.e. opcode and operand encoding!
Thanks for your review!
Maciej
More information about the Binutils
mailing list