[PATCH] *-*-hpux*: Don't use build_wrapper in copy_setup on hpux

Alan Modra amodra@gmail.com
Fri Aug 28 14:34:09 GMT 2020


On Fri, Aug 28, 2020 at 09:54:24AM -0400, John David Anglin wrote:
> On 2020-08-28 1:16 a.m., Alan Modra wrote:
> > On Thu, Aug 27, 2020 at 04:49:56PM -0400, John David Anglin wrote:
> >> diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp
> >> index 9877f3d310..eaa3db19ea 100644
> >> --- a/binutils/testsuite/binutils-all/objcopy.exp
> >> +++ b/binutils/testsuite/binutils-all/objcopy.exp
> >> @@ -631,7 +631,11 @@ proc copy_setup { } {
> >>      global test_prog
> >>      global host_triplet
> >>
> >> -    set res [build_wrapper testglue.o]
> >> +    if { ![istarget *-*-hpux*] } {
> >> +	set res [build_wrapper testglue.o]
> >> +    } else {
> >> +	set res ""
> >> +    }
> >>      set flags { debug }
> >>
> >>      if { [istarget *-*-uclinux*] && ![istarget tic6x-*-*] && ![istarget arm*-*-uclinuxfdpiceabi] } {
> > That can't be correct.  It shouldn't depend on target, since I can run
> > the testsuite on a cross from x86_64-linux to hppa-hp-hpux10 say
> > without seeing the problem you run into on native hpux.  In fact, what
> > you should be testing is "am I linking with GNU ld?", or really, a
> > linker that supports -wrap.
> I take your point but I don't believe that it's possible to run these tests on a cross from
> x86_64-linux to hppa-hp-hpux10 as they depend on the native linker for hppa-hp-hpux10.
> It only runs on hppa-hp-hpux10 and I don't believe the x86_64-linux linker can create
> SOM compatible binaries.

Oh, right, we don't build ld for hppa-hp-hpux10.  But we do for
hppa64-hp-hpux11.23.  So is there some possibility you might have GNU
ld installed for hppa64-hpux?

> 
> Maybe ishost or isnative would be better than istarget but I'm not sure how to properly avoid using
> build_wrapper.

I'd be happy with ishost.

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list