gas warning fixes
Alan Modra
amodra@gmail.com
Tue Aug 25 13:24:27 GMT 2020
Some versions of gcc with -Werror=format-overflow complain about using
a perfectly good 7 char buffer for "r%dr%d" when the int is between 0
and 64, apparently not seeing the value range.
note: ‘__builtin___sprintf_chk’ output between 5 and 24 bytes into a destination of size 7
* config/tc-arc.c (declare_register_set): Avoid false positive
format-overflow warning.
* config/tc-epiphany.c (md_assemble): Likewise.
* config/tc-mips.c (md_begin): Likewise.
* config/tc-mmix.c (mmix_md_begin): Likewise.
* config/tc-nds32.c (nds32_elf_append_relax_relocs): Avoid false
positive "may be used uninitialized" warning.
diff --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c
index 32369a56a1..bafa2a5eec 100644
--- a/gas/config/tc-arc.c
+++ b/gas/config/tc-arc.c
@@ -2562,7 +2562,7 @@ declare_register_set (void)
int i;
for (i = 0; i < 64; ++i)
{
- char name[7];
+ char name[32];
sprintf (name, "r%d", i);
declare_register (name, i);
diff --git a/gas/config/tc-epiphany.c b/gas/config/tc-epiphany.c
index 836b23b710..552f7dac15 100644
--- a/gas/config/tc-epiphany.c
+++ b/gas/config/tc-epiphany.c
@@ -550,7 +550,7 @@ md_assemble (char *str)
if (push && regmask)
{
- char buff[20];
+ char buff[32];
int i,p ATTRIBUTE_UNUSED;
epiphany_assemble ("mov r15,4");
@@ -570,7 +570,7 @@ md_assemble (char *str)
}
else if (pop && regmask)
{
- char buff[20];
+ char buff[32];
int i,p;
epiphany_assemble ("mov r15,4");
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index b1786824f9..00e9eceef1 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -3806,7 +3806,7 @@ md_begin (void)
for (i = 0; i < 32; i++)
{
- char regname[6];
+ char regname[16];
/* R5900 VU0 floating-point register. */
sprintf (regname, "$vf%d", i);
diff --git a/gas/config/tc-mmix.c b/gas/config/tc-mmix.c
index c469a62f0e..82a9f8318b 100644
--- a/gas/config/tc-mmix.c
+++ b/gas/config/tc-mmix.c
@@ -780,7 +780,7 @@ mmix_md_begin (void)
/* We always insert the ordinary registers 0..255 as registers. */
for (i = 0; i < 256; i++)
{
- char buf[5];
+ char buf[16];
/* Alternatively, we could diddle with '$' and the following number,
but keeping the registers as symbols helps keep parsing simple. */
diff --git a/gas/config/tc-nds32.c b/gas/config/tc-nds32.c
index 62bbad7409..b23f32676c 100644
--- a/gas/config/tc-nds32.c
+++ b/gas/config/tc-nds32.c
@@ -6053,6 +6053,7 @@ nds32_elf_append_relax_relocs (const char *key, const void *value)
fixup_size = fixup_now->size;
/* Insert all fixup. */
+ pcrel = 0;
while (fixup_size != 0 && fixup_now->offset == offset)
{
/* Set the real instruction size in element. */
--
Alan Modra
Australia Development Lab, IBM
More information about the Binutils
mailing list