PING: V4 [PATCH] gas: Extend .symver directive

H.J. Lu hjl.tools@gmail.com
Wed Apr 22 01:19:45 GMT 2020


On Tue, Apr 21, 2020 at 4:52 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Wed, Apr 22, 2020 at 08:50:06AM +0930, Alan Modra wrote:
> > avr-elf  +FAIL: symver symver11
> > d10v-elf  +FAIL: symver symver11
> > dlx-elf  +FAIL: symver symver11
> > ip2k-elf  +FAIL: symver symver11
> > m68k-elf  +FAIL: symver symver11
> > mcore-elf  +FAIL: symver symver11
> > msp430-elf  +FAIL: symver symver7
> > pj-elf  +FAIL: symver symver11
> > s12z-elf  +FAIL: symver symver11
> > shle-unknown-netbsdelf  +FAIL: symver symver11
> > sh-linux  +FAIL: symver symver11

I am checking in this for sh targets:

diff --git a/gas/testsuite/gas/symver/symver11.s
b/gas/testsuite/gas/symver/symver11.s
index 547e8123f0..08416be0f0 100644
--- a/gas/testsuite/gas/symver/symver11.s
+++ b/gas/testsuite/gas/symver/symver11.s
@@ -6,4 +6,5 @@ foo:
   .size foo,.-foo
   .symver foo,foo@@version2,remove
   .symver foo,foo@version1
+  .balign 8
   .dc.a foo

> > sh-nto  +FAIL: symver symver11
> > sh-rtems  +FAIL: symver symver11
> > visium-elf  +FAIL: symver symver11
> > xc16x-elf  +FAIL: symver symver11
> > z80-elf  +FAIL: symver symver11
>
> All of the symver11 fails except the sh ones are due to the symbol
> actually being removed!  As it is supposed to be, if not used in a
> relocation.  And those targets happen to reduce the reference to foo
> down to a section symbol.

foo is a global symbol.  Should assembler not reduce its reference
to a section symbol?  If these targets have to do it, I can skip this test
for these targets.

> I wonder if ".symver intsym, extsym@@nodename, remove" ought to really
> remove the symbol resulting in an assembly error if referenced?
>

A testcase?

-- 
H.J.


More information about the Binutils mailing list