[PATCH][Binutils][Arm] BFD: Exclude sections with no content from compress check.
Tamar Christina
Tamar.Christina@arm.com
Tue Apr 21 15:50:31 GMT 2020
Hi Nick,
>
> > Cross-compiled and regtested on
> > aarch64-none-linux-gnu, aarch64_be-none-linux-gnu,
> > arm-none-eabi, armeb-none-eabi, arm-wince-pe
>
> Since your patch affects generic code, please could you widen your testing ?
> At least include x86_64-pc-linux-gnu and maybe a toolchain configured with -
> -enable-targets=all.
Ah I have tested x86_64-pc-linux-gnu and it's clean, I have also tried one configured with --enable-targets=all
and while the build seems to have taken longer I don't see the number of tests actually increasing.
I am just doing ../binutils-gdb-fsf/configure --prefix=(readlink -f .)/install; and make -j; and make check -j
Do I need to do something else?
I did however already commit the patch after Alan's approval.
>
> The added code also references PR 24753, but this thread has not be
> included in that PR. Ideally it would be nice if you could reopen the PR and
> add your patch there, so that there is a permanent record of the addition
> which is easy to locate based on the comment. Also, if you do this, please
> reference the PR in the changelog message.
Sorry I noticed after I sent it out that I forgot to add the PR. The PR was added however before I committed it
so the commits are on Bugzilla.
In general should re-open old PRs before committing to them?
Thanks,
Tamar
>
> Cheers
> Nick
>
More information about the Binutils
mailing list