[PATCH] elf: Remove zero-sized relocation section from section group

Alan Modra amodra@gmail.com
Sat Apr 4 00:36:01 GMT 2020


On Fri, Apr 03, 2020 at 01:48:42PM -0700, H.J. Lu wrote:
> On Thu, Apr 2, 2020 at 9:45 PM Alan Modra <amodra@gmail.com> wrote:
> >
> > On Thu, Apr 02, 2020 at 08:41:18PM -0700, H.J. Lu via Binutils wrote:
> > > We must keep zero-sized relocation section in a section group.  Otherwise,
> > > the relocation section will be missing from the section group.
> >
> > Wouldn't it be better to get rid of these bogus relocation sections?
> > Should be possible with a change to _bfd_elf_fixup_group_sections, I
> > think.
> 
> Here is the patch which does that.  OK for master?

OK, thanks.

Hmm, do we want a warning message?  I'm OK with it as a reminder to
people to fix their compilers and/or assembly, but other than that it
seems to me that removing an empty relocation section is hardly of
concern to users.  How was your testcase generated?

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list