[PATCH] gas: Fix some x86_64 testcases for Solaris not using R_X86_64_PLT32 [PR25732]

H.J. Lu hjl.tools@gmail.com
Wed Apr 1 10:58:58 GMT 2020


On Wed, Apr 1, 2020 at 3:47 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
> As reported in PR gas/25732, some testcases currently FAIL on
> Solaris/x86:
>
> FAIL: x86-64 branch 2
> FAIL: x86-64 branch 3
> FAIL: x86-64 MPX branch
> FAIL: x86-64 branch with BND prefix
> FAIL: x86-64 jump
>
> Since https://sourceware.org/ml/binutils/2019-03/msg00163.html, gas
> doesn't emit R_X86_64_PLT32 as branch marker on Solaris.  Since the
> testsuite lacks a way to preprocess dump files, adjusted copies of the
> affected dumps are now used on Solaris.  Unfortunately, those dumps
> weren't adapted when the original testcases were changed or other
> testcases started to differ between non-Solaris and Solaris targets.
>
> The following patch fixes that, re-syncing the affected dump files or
> creating new Solaris-specific ones.
>
> Tested on i386-pc-solaris2.11, x86_64-pc-solaris2.11,
> x86_64-pc-linux-gnu, and i686-pc-linux-gnu.
>
> Ok for master?
>

OK.

BTW, please watch out for future adjustments similar to this.

Thanks.

-- 
H.J.



More information about the Binutils mailing list