[PATCH v4 00/35] CTF linking support

Nick Alcock nick.alcock@oracle.com
Wed Sep 25 15:13:00 GMT 2019


On 25 Sep 2019, Alan Modra uttered the following:

> On Wed, Sep 25, 2019 at 02:59:43PM +0100, Nick Alcock wrote:
>> On 25 Sep 2019, Alan Modra uttered the following:
>> 
>> > So I applied this series and the first thing I noticed was a whole lot
>> > of "git am" complaints.  In my .git/config I have
>> > [core]
>> > ...
>> >         whitespace = indent-with-non-tab,space-before-tab,trailing-space
>> > to help keep my own patches consistent with how most binutils files
>> > are formatted.  Please don't introduce more inconsistencies.
>> 
>> These are all from generated code, introduced by Automake: the source
>> has no trailing whitespace.
>
> It was indentation with spaces that I particularly noticed.  eg. this
> one from _bfd_elf_assign_file_positions_for_non_load

Oh! I quite failed to notice all of those (obviously), probably since
git diff didn't highlight them.

... hmm, ok, I think I have a regex that'll trap them, and indentation
with embedded spaces too (which the whitespace thing above would have
caught, but which was not the only problem here):

grep -E '^+(\t? +\t)|([ \t]*( ){8,})' *.patch

I'll fix everything that points out. Quite a lot has crept in, so some
of it will be in a patch stuck on the end of this series.



More information about the Binutils mailing list