RFC: Is it OK to disassemble instructions twice ?

Nick Clifton nickc@redhat.com
Wed Sep 11 11:10:00 GMT 2019


Hi Alan,

> Yes, that part is fine.  However, you had
> 
>   if (distance_to_rel > 0
>       && aux->abfd->arch_info->max_reloc_offset_into_insn <= distance_to_rel)
> 
> and initialised all (or practically all, I didn't check in detail) the
> max_reloc_offset_into_insn fields to zero.  That would make all
> targets that set disassembler_needs_relocs disassemble insns twice.

Doh!  Sorry, I totally missed that.  Please apply your fix.  Thanks. :-)

Cheers
  Nick




More information about the Binutils mailing list