[patch] Fix PR ld/24574

Alan Modra amodra@gmail.com
Fri Sep 6 00:10:00 GMT 2019


On Thu, Sep 05, 2019 at 05:56:57PM +0200, Eric Botcazou wrote:
> slightly scary comment:
> 
> -	      /* We replace original name with __imp_ prefixed, this
> -		 1) may trash memory 2) leads to duplicate symbol generation.
> -		 Still, IMHO it's better than having name polluted.  */
> -	      undef->root.string = sym->root.string;

"may trash memory" is alarmist.  Replacing a pointer to a string
(typically in memory containing a copy of .strtab or .dynstr) with a
pointer to another string won't "trash memory".

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list