[PATCH 1/2] Fix size of dos_message type in internal_extra_pe_filehdr

Nick Clifton nickc@redhat.com
Tue Oct 29 08:06:00 GMT 2019


Hi Andrew,

> Is there anyone available to review these patches?

Sorry - I missed these.

>> -  unsigned long dos_message[16]; /* text which always follows dos header */
>> +  unsigned int dos_message[16]; /* text which always follows dos header */

Patch approved and applied.

I guess that strictly speaking if it is important that this field be
64 bytes long then it should be declared as "char[64]" (although even
that would not work on hosts with 32-bit chars).  But this would mean
reworking more of the code, and your patch is simple and clean, so I
have gone ahead and committed it.

Are there other patches that need review ?  If so, please feel free to
ping this list.

Cheers
  Nick




More information about the Binutils mailing list