[PATCH 3/9] binutils: Rename init_dwarf_regnames

Palmer Dabbelt via binutils binutils@sourceware.org
Fri Nov 22 22:00:00 GMT 2019


On Fri, 22 Nov 2019 04:10:27 PST (-0800), andrew.burgess@embecosm.com wrote:
> As part of a process to change how dwarf.c figures out the correct
> name for a register I wanted to clean up how we initialise the
> register name tracking state.
>
> As part of this I rename init_dwarf_regnames to
> init_dwarf_regnames_by_elf_machine_code, later commits will add a
> different entry point to initialise the register name state.
>
> There should be no user visible changes after this commit.
>
> binutils/ChangeLog:
>
> 	* dwarf.c (init_dwarf_regnames): Renamed to...
> 	(init_dwarf_regnames_by_elf_machine_code): ...this.
> 	* dwarf.h (init_dwarf_regnames): Renamed to...
> 	(init_dwarf_regnames_by_elf_machine_code): ...this.
> 	* readelf.c (process_file_header): Update call to use new name.
>
> Change-Id: Ic8d2ef5fb62a8590ecd8cbb7e6258e11c6263594
> ---
>  binutils/ChangeLog | 8 ++++++++
>  binutils/dwarf.c   | 2 +-
>  binutils/dwarf.h   | 2 +-
>  binutils/readelf.c | 2 +-
>  4 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/binutils/dwarf.c b/binutils/dwarf.c
> index 62f2817d183..c888aad3988 100644
> --- a/binutils/dwarf.c
> +++ b/binutils/dwarf.c
> @@ -7590,7 +7590,7 @@ init_dwarf_regnames_riscv (void)
>  }
>
>  void
> -init_dwarf_regnames (unsigned int e_machine)
> +init_dwarf_regnames_by_elf_machine_code (unsigned int e_machine)
>  {
>    switch (e_machine)
>      {
> diff --git a/binutils/dwarf.h b/binutils/dwarf.h
> index ca2f062efb7..204f00ef53d 100644
> --- a/binutils/dwarf.h
> +++ b/binutils/dwarf.h
> @@ -225,7 +225,7 @@ extern unsigned long dwarf_start_die;
>
>  extern int dwarf_check;
>
> -extern void init_dwarf_regnames (unsigned int);
> +extern void init_dwarf_regnames_by_elf_machine_code (unsigned int);
>  extern void init_dwarf_regnames_i386 (void);
>  extern void init_dwarf_regnames_iamcu (void);
>  extern void init_dwarf_regnames_x86_64 (void);
> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index fab8214664c..1d8f62bf50b 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -4852,7 +4852,7 @@ process_file_header (Filedata * filedata)
>        return FALSE;
>      }
>
> -  init_dwarf_regnames (header->e_machine);
> +  init_dwarf_regnames_by_elf_machine_code (header->e_machine);
>
>    if (do_header)
>      {

Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>



More information about the Binutils mailing list