[PATCH] x86: drop redundant SYSCALL/SYSRET templates

Jan Beulich jbeulich@suse.com
Wed Nov 13 13:19:00 GMT 2019


On 12.11.2019 21:45,  H.J. Lu  wrote:
> On Mon, Nov 11, 2019 at 11:19 PM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 11.11.2019 18:15,  H.J. Lu  wrote:
>>> On Mon, Nov 11, 2019 at 4:01 AM Jan Beulich <jbeulich@suse.com> wrote:
>>>> --- a/opcodes/i386-opc.tbl
>>>> +++ b/opcodes/i386-opc.tbl
>>>> @@ -2797,9 +2797,7 @@ pswapd, 2, 0xf0f, 0xbb, 2, Cpu3dnowA, Mo
>>>>
>>>>  // AMD extensions.
>>>>  syscall, 0, 0xf05, None, 2, CpuSYSCALL, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { 0 }
>>>> -syscall, 0, 0xf05, None, 2, Cpu64, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { 0 }
>>>>  sysret, 0, 0xf07, None, 2, CpuSYSCALL, DefaultSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { 0 }
>>>> -sysret, 0, 0xf07, None, 2, Cpu64, DefaultSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { 0 }
>>>>  swapgs, 0, 0xf01f8, None, 3, Cpu64, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { 0 }
>>>>  rdtscp, 0, 0xf01f9, None, 3, CpuRdtscp, No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf, { 0 }
>>>
>>> Can you add a testcase?
>>
>> The insns are being tested already, so I wonder what you want to be
>> tested in addition. What completely lacks testing are SYSENTER/SYSEXIT.
> 
> That is fine then.

I'll take this as an OK to the original patch then.

Thanks, Jan



More information about the Binutils mailing list