[PATCH v2] readelf: Fixes for IN_RANGE

[Christian Eggers]

Hi Nick,

> Hi Christian,
>
> > Various small fixes for the IN_RANGE macro.
>
> Given the size of these patches, it would have been simpler
> just to submit them as one single patch....
done

> Including ChangeLog entries is very nice, but please could you
> provide them as plain text, and not a context diff.  The diff
> almost never applies cleanly because the ChangeLogs are being
> constantly updated.
done

> I think that what we need here is a comment to make it clear what the
> macro is doing.  Something like:

> /* Evaluates to to TRUE if the region ADDR..ADDR+SIZE-1 is contained
> within the address range START..END-1.  */
done

> [...]
> Also note - your mailer has corrupted the context diff, adding "3D" after
> the = sign, and then wrapping the lines at 80 characters.   If you cannot
> turn this behaviour off, then could you provide the patches as attachments,
> rather than inline please.

I sent the patches directly from git via "git send-email". Although the
encoding of the cover letter can be modified via command line, the
individual patch messages were always encoded "quoted printable".

This time I'm sending the patch via kmail according to the instructions
in git-format-patch(1). Even here the mail gets encoded "quoted
printable" if the patch is inline (so I attached it this time).

> Note - this patch is wrong if fix 3/4 is applied as the test needs to check
> for rloc >= end, whereas IN_RANGE would check for rloc > end.  If however
> 3/4 is not applied (as suggested above) then this patch is OK.
Is this issue solved now?

regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-readelf-Various-fixes-for-IN_RANGE.patch
Type: text/x-patch
Size: 2134 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20191105/1f77da79/attachment.bin>