[PATCH] libctf: mark swap.h inline functions as static

Joey Ye joey.ye.cc@gmail.com
Fri Nov 1 14:59:00 GMT 2019


Hi Simon,

I believe bswap_identity_64 need to be changed to static inline as
well. Generally C compilers are not friendly to "inline" keyword
along.

Also may I request backport this and a coming bswap_identity_64 to
2.33 branch please? Without this fix Binutils fails to build with
CFLAGS=-O0 in all platforms.

Thanks,
Joey

On Wed, Oct 16, 2019 at 7:17 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> On 16 Oct 2019, Simon Marchi spake thusly:
> > On 2019-10-15 10:15 a.m., Nick Alcock wrote:
> >> (... and could anyone review the GDB testsuite fix stuff I've had
> >> outstanding for a few days now? I'm hoping I can push it and the acked
> >> stuff that is first in that patch series before everything changes under
> >> it so much I have to redo it all... :) )
> >
> > It seems like Tom has looked at it now?
>
> Yes indeed! I'll be posting a revised series shortly (probably later
> tonight).
>
> --
> NULL && (void)



More information about the Binutils mailing list