On Sun, May 26, 2019 at 11:37 PM Kito Cheng <kito@andestech.com> wrote: > gas/ChangeLog: > * doc/c-riscv.texi (Instruction Formats): Add r4 type. > opcodes/ChangeLog: > * riscv-opc.c (riscv_insn_types): Add r4 type. There should be testcases added for the new r4 type. Otherwise this looks OK. Jim