[PATCH v2 00/19] libctf, and CTF support for objdump and readelf

[Alan Modra]

On Tue, May 28, 2019 at 10:36:17PM +0100, Nix wrote:
> On 28 May 2019, Christophe Lyon stated:
> > One of the patches in the series broke the build for --target arm-pe:
> > ../libctf/libctf.a(ctf-open-bfd.o): In function `ctf_bfdopen_ctfsect':
> > /home/tcwg-buildslave/workspace/tcwg-binutils/bfd/--enable-64-bit-bfd=no/label/tcwg-x86_64-cam/target/arm-pe/build-arm-pe/libctf/../../libctf/ctf-open-bfd.c:136:
> > undefined reference to `bfd_section_from_elf_index'
> > /home/tcwg-buildslave/workspace/tcwg-binutils/bfd/--enable-64-bit-bfd=no/label/tcwg-x86_64-cam/target/arm-pe/build-arm-pe/libctf/../../libctf/ctf-open-bfd.c:145:
> > undefined reference to `bfd_section_from_elf_index'
> >
> > Can you check & fix?
> 
> Very sorry about that. My non-ELF platform of choice was mingw, which I
> now see pulls in the ELF bfd stuff! Ironically I had all the necessary
> ifdefs in place for the non-ELF builds but was intentionally trimming
> them out of the copy synced to binutils...
> 
> I am testing the fix below (on lots more targets, this time, so it might
> be a few hours). I hope the build system fiddling is right. It was... a
> bit counterintuitive, although all the changes made sense in hindsight.

It looks OK to me and fixes build failures on these targets that I test:
alpha-dec-vms
arm-pe
arm-wince-pe
hppa-hp-hpux10
i386-darwin
mcore-pe
ns32k-netbsd
ns32k-pc532-mach
pdp11-dec-aout
powerpc-aix5.1
powerpc-aix5.2
powerpcle-cygwin
rs6000-aix4.3.3
rs6000-aix5.1
rs6000-aix5.2
sh-pe
tic30-unknown-aout
tic30-unknown-coff
tic4x-coff
tic54x-coff
z80-coff
z8k-coff

-- 
Alan Modra
Australia Development Lab, IBM