[PATCH binutils 4/4] aarch64: handle STO_AARCH64_VARIANT_PCS in bfd

Christophe Lyon christophe.lyon@linaro.org
Sun May 26 08:51:00 GMT 2019


On Thu, 23 May 2019 at 13:11, Szabolcs Nagy <Szabolcs.Nagy@arm.com> wrote:
>
> Propagate STO_AARCH64_VARIANT_PCS st_other attribute to the output and
> add DT_AARCH64_VARIANT_PCS dynamic tag if necessary.
>
> Mismatching attributes are not diagnosed.
>
> bfd/ChangeLog:
>
> 2019-05-22  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>
>         * elfnn-aarch64.c (elfNN_aarch64_merge_symbol_attribute): New function.
>         (struct elf_aarch64_link_hash_table): Add variant_pcs member.
>         (elfNN_aarch64_allocate_dynrelocs): Update variant_pcs.
>         (elfNN_aarch64_size_dynamic_sections): Add DT_AARCH64_VARIANT_PCS.
>         (elf_backend_merge_symbol_attribute): Define.
>
> ld/ChangeLog:
>
> 2019-05-22  Szabolcs Nagy  <szabolcs.nagy@arm.com>
>
>         * testsuite/ld-aarch64/aarch64-elf.exp: Add new tests.
>         * testsuite/ld-aarch64/variant_pcs-1.s: New asm for tests.
>         * testsuite/ld-aarch64/variant_pcs-2.s: New asm for tests.
>         * testsuite/ld-aarch64/variant_pcs-now.d: New test.
>         * testsuite/ld-aarch64/variant_pcs-r.d: New test.
>         * testsuite/ld-aarch64/variant_pcs-shared.d: New test.
>         * testsuite/ld-aarch64/variant_pcs.ld: New linker script for tests.

Hi,

I have noticed that some new tests fail on aarch64-elf:
FAIL: ld-aarch64/variant_pcs-now
FAIL: ld-aarch64/variant_pcs-shared

Christophe



More information about the Binutils mailing list