[PATCH binutils 1/4] aarch64: add STO_AARCH64_VARIANT_PCS and DT_AARCH64_VARIANT_PCS
Nick Clifton
nickc@redhat.com
Fri May 24 11:01:00 GMT 2019
Hi Jan,
>>> + static char buf[32];
>>> + snprintf (buf, sizeof buf, "VARIANT_PCS | %x", other);
>> On a host where an unsigned int is a 64-bit quantity, it is
>> theoretically possible for the snprintf function to have to
>> truncate the output, possibly confusing the user. Could you
>> increase the buffer size a little bit please ?
>
> Hmm, %x can be at most 16 digits then, and I count 14
> literal characters and a nul. I.e. 32 looks to be sufficient
> for that case.
Oh bananas - yes you are right - I can't count. Please ignore this request. :-)
Cheers
Nick
More information about the Binutils
mailing list