[PATCH] GAS: Replace macro LITERAL_PREFIXDOLLAR_HEX with a runtime value.

Nick Clifton nickc@redhat.com
Mon May 20 15:40:00 GMT 2019


Hi John,

> +  literal_prefix_dollar_hex = 1;

I am tempted to suggest that this variable should be called "literal_hex_prefix"
and contain a string, or possibly just a character that should be interpreted
as being a prefix for hex strings.  But this is probably over complicating things,
so instead...

> +int literal_prefix_dollar_hex = 0;

... since this is a boolean variable, its type should be bfd_boolean and it should
be initialised to FALSE.

Patch approved with that change made (and the other places where it is set to 1 
replaced with TRUE, obviously).

Cheers
  Nick




More information about the Binutils mailing list